chore(android): bump core min sdk #5503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested changes
Mar 15, 2022
There was a problem hiding this comment.
I like to do changes on android-template (and ios-template) in separate PRs, so it's easier to spot the changes users need to do when updating and we can link the commits in the docs if needed.
For the android/core part, it also needs to be changed on
Line 242 in ba84443
and
|
Makes sense, I've adjust the PR |
IT-MikeS
changed the title
IT-MikeS
changed the title
giralte-ionic
approved these changes
Mar 15, 2022
jcesarmobile
changed the title
jcesarmobile
approved these changes
Mar 15, 2022
|
Guys, why do you manually update the minSdkVersion? What is the problem to give the user some option to set the version by themself? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses: WN-345